Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBA Cheats: PARv3 "Always skip..." code not accepted #915

Closed
Prof9 opened this issue Oct 19, 2017 · 2 comments
Closed

GBA Cheats: PARv3 "Always skip..." code not accepted #915

Prof9 opened this issue Oct 19, 2017 · 2 comments
Labels
platform:GBA Game Boy Advance-related issues severity:enhancement Feature requests
Milestone
mGBA 0.10.0

Comments

@Prof9
Copy link
Contributor

Prof9 commented Oct 19, 2017

On 523aaf1, when a PARv3 code is entered that contains any "Always skip..." lines, those lines are silently dropped after entering.

Example:

0E200000 00000000	Always skip next line
00200000 00000000	[02000000] <- 00
4E200000 00000000	Always skip next two lines
00200000 00000000	[02000000] <- 00
00200000 00000000	[02000000] <- 00
8E200000 00000000	Always skip all next lines
00200000 00000000	[02000000] <- 00
CE200000 00000000	Always skip all lines
00200000 00000000	[02000000] <- 00

Encrypted:

B56B9D45 07E0F540
E77D3CEF 1E6445A7
92B37196 65ECFBBE
E77D3CEF 1E6445A7
E77D3CEF 1E6445A7
C74EE9AC 0AD5403C
E77D3CEF 1E6445A7
191355E2 1EB1101A
E77D3CEF 1E6445A7

After entering in mGBA:

E77D3CEF 1E6445A7
E77D3CEF 1E6445A7
E77D3CEF 1E6445A7
E77D3CEF 1E6445A7
E77D3CEF 1E6445A7

I went back and checked on 0.6.0, too -- which precedes 348b33c. The same behavior occurs there.

At the very least, the "always skip next line" and "always skip next two lines" codes would be quite nice to have, as they let one invert the If-AND code type for PARv3 and create a code that ORs a specific bit. For example:

3820224A 00000001
0E200000 00000000
8020224A 00000001

Though there is another way to achieve that which also uses 3 lines, so it's not a huge deal.
@endrift
Copy link
Member

endrift commented Oct 20, 2017

Yeah I never added this because I didn't know if there was much use for it.

@endrift endrift added platform:GBA Game Boy Advance-related issues severity:enhancement Feature requests labels Oct 20, 2017
@endrift endrift added this to the mGBA 0.7.0 milestone Dec 27, 2017
@endrift endrift modified the milestones: mGBA 0.7.0, mGBA 0.7.1 Jan 3, 2019
@endrift endrift modified the milestones: mGBA 0.7.1, mGBA 0.7.2 Feb 25, 2019
@endrift endrift modified the milestones: mGBA 0.7.2, mGBA 0.8.0 May 25, 2019
@endrift endrift modified the milestones: mGBA 0.8.0, mGBA 0.9.0 Jan 22, 2020
@endrift endrift modified the milestones: mGBA 0.9.0, mGBA 0.10.0 Jan 24, 2021
@endrift
Copy link
Member

endrift commented Feb 23, 2022

Hope I got this right. Let me know and I can reopen it if it's still broken.

rtomasa pushed a commit to rtomasa/mgba that referenced this issue Sep 15, 2023
@endrift @rtomasa
GBA Cheats: Implement "never" type codes (closes mgba-emu#915)
b408989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:GBA Game Boy Advance-related issues severity:enhancement Feature requests
Projects
None yet
Milestone
mGBA 0.10.0
Development

No branches or pull requests
2 participants
@endrift @Prof9