Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: mute audio while fast-forwarding #846

Closed
autofire372 opened this issue Aug 5, 2017 · 8 comments
Closed

Feature Request: mute audio while fast-forwarding #846

autofire372 opened this issue Aug 5, 2017 · 8 comments
Labels
feature:usability UX issues due to unclear UI port:Qt Affects the Qt version (the standard desktop version) severity:enhancement Feature requests
Milestone

Comments

@autofire372
Copy link

autofire372 commented Aug 5, 2017

Revision 0.7-4752-36c1fb59 broke fast-forwarding; trying to fast-forward now results in a brief burst of speed, and then the game regresses to normal speed but with sound issues that, fortunately, do not persist when fast-forward is disabled.

EDIT: I have discovered another issue involving fast-forwarding: if fast-forward speed is set to anything other than unbounded, audio gets pitched up into a tinny screech.

@endrift
Copy link
Member

endrift commented Aug 6, 2017

Can't reproduce on macOS. What OS are you on?

@autofire372
Copy link
Author

Windows 10 x64

@autofire372
Copy link
Author

I've isolated the issue a bit further: it only occurs when the OpenGL video driver is used. Software and OGL 1.x both work fine.

@waddlesplash
Copy link
Contributor

Can't reproduce on 0.6.0 on Win10 x64 here. I do note, though, that the first time I hit to fast-forward it doesn't do anything, but the second and all subsequent times work just fine.

@waddlesplash waddlesplash added the category:questionable Issues that may not be actual issues label Aug 6, 2017
@autofire372
Copy link
Author

autofire372 commented Aug 6, 2017

@waddlesplash, I never said the bug happened in 0.6.0. It only started in recent 0.7 dev builds.

@endrift
Copy link
Member

endrift commented Aug 14, 2017

Re: your edit, that's not a bug. It might be a bit undesirable (muting might be better) but it's not a bug.

@autofire372
Copy link
Author

The bug I reported turned out to be an issue with my NVIDIA driver settings, so you can ignore that. Please keep this open as a feature request for the ability to mute audio while fast-forwarding.

@autofire372 autofire372 changed the title Fast-forwarding is broken Feature Request: mute audio while fast-forwarding Aug 18, 2017
@endrift endrift added feature:usability UX issues due to unclear UI port:Qt Affects the Qt version (the standard desktop version) severity:enhancement Feature requests and removed category:questionable Issues that may not be actual issues labels Aug 19, 2017
@endrift endrift added this to the mGBA 0.7.0 milestone Aug 19, 2017
@endrift
Copy link
Member

endrift commented Sep 2, 2018

See also #1143, which I'm going to implement at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:usability UX issues due to unclear UI port:Qt Affects the Qt version (the standard desktop version) severity:enhancement Feature requests
Projects
None yet
Development

No branches or pull requests

3 participants