Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprite export crash #841

Closed
Cj-Malone opened this issue Aug 4, 2017 · 3 comments
Closed

Sprite export crash #841

Cj-Malone opened this issue Aug 4, 2017 · 3 comments

Comments

@Cj-Malone
Copy link

When exporting a sprite (via Tools, Sprites, Export) the game (Pokemon Emerald GBA) crashes, but not the program. I managed to do a quick fix myself by commenting out an interrupter, but I guess a real fix would actually be to resume the interrupt? Anyway this is my diff that got it to work.

diff --git a/src/platform/qt/ObjView.cpp b/src/platform/qt/ObjView.cpp
index 871a95cb..a6e356bc 100644
--- a/src/platform/qt/ObjView.cpp
+++ b/src/platform/qt/ObjView.cpp
@@ -248,7 +248,7 @@ void ObjView::updateTilesGB(bool force) {
 
 #ifdef USE_PNG
 void ObjView::exportObj() {
-       CoreController::Interrupter interrupter(m_controller);
+       // CoreController::Interrupter interrupter(m_controller);
        QString filename = GBAApp::app()->getSaveFileName(this, tr("Export sprite"),
                                                          tr("Portable Network Graphics (*.png)"));
        VFile* vf = VFileDevice::open(filename, O_WRONLY | O_CREAT | O_TRUNC);
@endrift
Copy link
Member

endrift commented Aug 4, 2017

Crashes what? The game?

@Cj-Malone
Copy link
Author

After some more looking around it turns out it just pauses the game, not crashes. And doesn't resume after extraction. I presume it's paused to make sure the sprite in memory isn't altered during extraction?

It's a bit counter intuitive to have the game stay paused after extraction, I think it should resume automatically.

@endrift
Copy link
Member

endrift commented Aug 5, 2017

I can reproduce that issue. Investigating.

@endrift endrift closed this as completed in d7fc097 Aug 5, 2017
endrift added a commit that referenced this issue Aug 12, 2017
@endrift
Qt: Fix sprite export pausing game indefinitely (fixes #841)
dce3744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endrift @Cj-Malone