Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIOS paths in Portable Mode #838

Closed
scottluker opened this issue Aug 3, 2017 · 11 comments
Closed

BIOS paths in Portable Mode #838

scottluker opened this issue Aug 3, 2017 · 11 comments
Labels
severity:enhancement Feature requests
Milestone

Comments

@scottluker
Copy link

When using mGBA in portable mode, if the BIOS paths are in the same directory as mGBA then they should be a relative path rather than an absolute path. This will make mGBA fully portable because you won't have to manually change the paths.

Or another solution to this is to have mGBA check a folder which you can place the bios files in and will be automatically used.

@scottluker
Copy link
Author

I know I can use .\ on windows, just though this would help other people.

@endrift
Copy link
Member

endrift commented Aug 3, 2017

It should automatically look in the same directory as the config file. If that's not working in portable mode that's a bug.

@endrift endrift added the severity:enhancement Feature requests label Aug 3, 2017
@endrift endrift added this to the mGBA 0.9.0 milestone Jul 6, 2020
@twoco
Copy link

twoco commented Jul 28, 2023

If you use ./ or no prefix (e.g. only bios/foo.bin it tries to locate the file from the ROM directory. It's ok. But how to define the relative path from the application folder where the mGBA.exe is located? Maybe both solutions are useful. Relative path of ROM and relative path of application. Use case: Either load and save files in ROM directory (with optional subfolders) as it currently works. Or organize all in the application path (portable). This is currently only possible with absolute pathes. Or did I miss something?

v0.10.2

@endrift endrift reopened this Jul 28, 2023
@endrift
Copy link
Member

endrift commented Jul 28, 2023

that sounds like a bug

@endrift endrift modified the milestones: mGBA 0.9.0, mGBA 0.10.3 Jul 28, 2023
@twoco
Copy link

twoco commented Jul 28, 2023

Not sure if this is a bug. Because you maybe want relative path to ROM directory. But also realtive path to the app (exe) folder is also a good option. But how to handle both. Or what is intended/expected?

We could use variables like {app}/bios/foo.bin and if nothing is set like ./bios/foo.bin uses from ROM dir.

@endrift
Copy link
Member

endrift commented Jul 28, 2023

Expected/intended is relative to the app folder.

@twoco
Copy link

twoco commented Jul 28, 2023

Ok, I started the ROM by double click one the file and open with (from Windows explorer). Not yet tried when open mGBA and open file manually.

@endrift
Copy link
Member

endrift commented Jul 28, 2023

Oh, I think that might be a different bug. I'd need to find the bug report for it though.

@endrift
Copy link
Member

endrift commented Jul 28, 2023

I believe it's #2826, which is fixed in dev but not in 0.10.2. Can you see what it does in a dev build?

@twoco
Copy link

twoco commented Jul 28, 2023

I tested it now:

  • If you load ROM after starting mGBA, then the relative path works as expected (app folder).
  • If you start mGBA with a ROM as paramter (open with; double click on file and link file with the exe), then relative path is rom folder (which is the issue).

Yes the linked issue seems to be the same issue.

@endrift
Copy link
Member

endrift commented Nov 6, 2023

In that case, it's already fixed, but won't be in 0.10.3, only 0.11.

@endrift endrift closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:enhancement Feature requests
Projects
None yet
Development

No branches or pull requests

3 participants