Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSMB: Incorrect Z-ordering in W8-3 #661

Closed
waddlesplash opened this issue Apr 14, 2017 · 2 comments
Closed

NSMB: Incorrect Z-ordering in W8-3 #661

waddlesplash opened this issue Apr 14, 2017 · 2 comments
Labels
hardware:3D Issues in the 3D pipeline subsystem platform:DS Nintendo DS-related issues software:priority game Issues in widely played popular games

Comments

@waddlesplash
Copy link
Contributor

See the bubble on the left -- the plant inside the bubble appears behind the green plant.
new super mario bros-4
@endrift endrift added hardware:3D Issues in the 3D pipeline subsystem platform:DS Nintendo DS-related issues labels Apr 14, 2017
@endrift endrift added the software:priority game Issues in widely played popular games label Apr 21, 2017
@Arisotura
Copy link

Related to polygon IDs, not Z, afaict. I saw the same bug while implementing polygon IDs in melonDS. I don't remember the exact cause, but basically: the polygon ID check for translucent pixels is only done when the destination pixel was translucent too (regardless of the stored alpha), except when drawing shadows.

(this, based on what I observed and tested. may be wrong)

@endrift
Copy link
Member

endrift commented Apr 24, 2017

I implemented that part of polygon ID stuff already. It was, for example, causing trees to show through each other in SM64 before I fixed it. Wonder if I got it wrong somehow.

endrift added a commit that referenced this issue Apr 25, 2017
@endrift
DS GX: Retain translucent polygon ID when drawing opaque fragments (f…
fd7d85c 
…ixes #661)
@endrift endrift closed this as completed Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:3D Issues in the 3D pipeline subsystem platform:DS Nintendo DS-related issues software:priority game Issues in widely played popular games
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@endrift @Arisotura @waddlesplash