Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameShark Save Import Not Working #658

Closed
wildgoosespeeder opened this issue Apr 13, 2017 · 8 comments
Closed

GameShark Save Import Not Working #658

wildgoosespeeder opened this issue Apr 13, 2017 · 8 comments
Labels
platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library
Milestone
0.6.0

Comments

@wildgoosespeeder
Copy link

wildgoosespeeder commented Apr 13, 2017 •
edited

I doubt this is mGBA's fault because this also happens in a 2004 version of VisualBoyAdvance and the current VBA-M release, even with vba-over.ini present and modified to account for the three Donkey Kong Country GBA games. I'm just trying to find answers why certain *.sps files don't take effect. I've had some successes and some failures with this import feature. I am having issues importing a GameShark Save for Donkey Kong Country 3 from GameFAQs. I go to the file select screen in-game after importing and I see no 101% saves. All slots are blank. Is there something wrong with the decoding algorithm in all three GBA emulators or are saves a pain in the butt (which has been an issue from the start of GBA emulation)?

https://www.gamefaqs.com/gba/928294-donkey-kong-country-3/saves
@endrift
Copy link
Member

endrift commented Apr 13, 2017

Please link to the GameShark Save you're using.

@wildgoosespeeder
Copy link
Author

wildgoosespeeder commented Apr 13, 2017 •
edited

So quick and linked!

@endrift
Copy link
Member

endrift commented Apr 14, 2017

The save looks valid. I'll investigate at some point.

@endrift endrift added platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library labels Apr 14, 2017
@endrift endrift added this to the 0.6.0 milestone Apr 14, 2017
@wildgoosespeeder
Copy link
Author

Would you like to know what other GameShark saves I tried? It isn't unique to Donkey Kong Country GBA game saves.

@endrift
Copy link
Member

endrift commented Jun 14, 2017

Should be fixed now.

endrift added a commit that referenced this issue Jun 14, 2017
@endrift
GBA Savedata: Update and fix Sharkport importing (fixes #658)
caa1d45
@wildgoosespeeder
Copy link
Author

wildgoosespeeder commented Jun 14, 2017 •
edited

Once the nightlies section of downloads updates on your website, I hope to test this for myself. It's still on a4faf9f. Thanks for the update.

@endrift
Copy link
Member

endrift commented Jun 14, 2017

That's odd. I'll look into why.

@wildgoosespeeder
Copy link
Author

wildgoosespeeder commented Jun 18, 2017 •
edited

I think it's now fixed because it is now 0f356a9 instead of a4faf9f. I can confirm that the same successfully imported! Thanks for the bugfix!

lotharsm pushed a commit to lotharsm/mgba that referenced this issue Jun 24, 2017
@endrift
GBA Savedata: Update and fix Sharkport importing (fixes mgba-emu#658)
037d855
lotharsm pushed a commit to lotharsm/mgba that referenced this issue Jun 24, 2017
@endrift
GBA Savedata: Update and fix Sharkport importing (fixes mgba-emu#658)
bddad6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@endrift @wildgoosespeeder