Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor layer issue in Kirby & The Amazing Mirror intro #532

Closed
SuperrSonic opened this issue Feb 24, 2017 · 4 comments
Closed

Minor layer issue in Kirby & The Amazing Mirror intro #532

SuperrSonic opened this issue Feb 24, 2017 · 4 comments
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library severity:regression Issues that were not present in previous versions
Milestone
mGBA 0.6.1

Comments

@SuperrSonic
Copy link
Contributor

After the intro stage a small cutscene plays:
test
Taken from VBA-M.

But in mGBA the star graphic behind the mirror can be seen before the mirror breaks.
kirby and the amazing mirrors3

State before the cutscene.
kirby and the amazing mirrors1
@endrift endrift modified the milestone: 0.6.1 Jun 18, 2017
@endrift endrift added platform:GBA Game Boy Advance-related issues hardware:2D Issues in the 2D/pixel pipeline subsystem severity:minor bug Issues that only have a minor impact on the library labels Jun 18, 2017
@endrift endrift added the blocked:needs hw testing May be present on actual hardware, but need confirmation label Sep 12, 2017
@vaguerant
Copy link

Per the category:needs hw testing tag, I tried this out (on a DS Lite). I can confirm the correct behavior is as shown in SuperrSonic's GIF of VBA-M. In mGBA, part of the mirror becomes translucent during the flashing screen effects, making the background's archway clearly visible where it should be blocked by the (opaque) mirror.

To supplement SuperrSonic's screenshot of the error in mGBA, here's a GIF of mGBA's behavior.
kirbyerrormgba

@endrift endrift added severity:regression Issues that were not present in previous versions and removed blocked:needs hw testing May be present on actual hardware, but need confirmation labels Sep 20, 2017
@endrift
Copy link
Member

endrift commented Sep 20, 2017

Can you confirm that the mirror and dark Meta Knight are brightened during the flash on hardware, and not just plainly visible during? Fixing that could be a major pain for me, and everything I know about the GBA's video hardware tells me they should be.

@endrift
Copy link
Member

endrift commented Sep 20, 2017

...that commit message is wrong.

Regardless, I'm pretty sure that hack is still wrong, so let me know if you find anything else.

@vaguerant
Copy link

Unfortunately (for you), yeah, I can confirm that Dark Meta Knight and the mirror are both brightened along with the rest of the scene. The whole screen is turned white during his attacks.

endrift added a commit that referenced this issue Sep 21, 2017
@endrift
GBA Video: Fix broken sprite blending hack (fixes #532)
2c3adf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library severity:regression Issues that were not present in previous versions
Projects
None yet
Milestone
mGBA 0.6.1
Development

No branches or pull requests
3 participants
@endrift @vaguerant @SuperrSonic