Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift key not displayed correctly in Keyboard settings #525

Closed
Prof9 opened this issue Feb 14, 2017 · 4 comments
Closed

Shift key not displayed correctly in Keyboard settings #525

Prof9 opened this issue Feb 14, 2017 · 4 comments
Labels
port:Qt Affects the Qt version (the standard desktop version) system:Windows Affects running on Windows
Milestone
mGBA 0.9.0

Comments

@Prof9
Copy link
Contributor

Prof9 commented Feb 14, 2017 •
edited

See image below, where Right Shift has been assigned to the Select button. It shows up as garbage in the settings, but it does work correctly in-game (as well as Left Shift). Using the latest nightly (17cfee0) on Windows 10 x64.

http://i.imgur.com/pbcmQaX.png
@endrift
Copy link
Member

endrift commented Feb 14, 2017

I'm under the impression that this is a Qt bug. I've seen it before.

@obskyr
Copy link

obskyr commented May 19, 2017

Can confirm! Interestingly enough, if you press shift together with another key (or within a short timeframe after pressing another key), it shows up just fine. Here I've juggled the interface enough to set Select to shift + left mouse (which just displays as Shift+), and Start to shift + M.

Settings

Incidentally, it turns out entering key combinations is possible although incredibly (incredibly) finicky.

@endrift
Copy link
Member

endrift commented May 19, 2017

For what it's worth, this entire interface is getting replaced when the input revamp is done. An early version of it was merged into medusa but it's...rather early still and buggy. It will probably need a full redesign, even.

@endrift endrift added the port:Qt Affects the Qt version (the standard desktop version) label May 19, 2017
@endrift endrift added this to the 0.7.0 milestone Jul 9, 2017
@endrift endrift added the system:Windows Affects running on Windows label Jul 9, 2017
@endrift endrift modified the milestones: mGBA 0.7.0, mGBA 0.7.1 Oct 16, 2018
@endrift endrift modified the milestones: mGBA 0.7.1, mGBA 0.7.2 Feb 25, 2019
@endrift endrift modified the milestones: mGBA 0.7.2, mGBA 0.8.0 May 25, 2019
@endrift endrift modified the milestones: mGBA 0.8.0, mGBA 0.9.0 Jan 22, 2020
@endrift
Copy link
Member

endrift commented Feb 15, 2020

Turns out this is a bug in Qt itself. I'll have to work around it.

endrift added a commit that referenced this issue Feb 15, 2020
@endrift
Qt: Fix invalid names for modifier keys (fixes #525)
a3f42ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
port:Qt Affects the Qt version (the standard desktop version) system:Windows Affects running on Windows
Projects
None yet
Milestone
mGBA 0.9.0
Development

No branches or pull requests
3 participants
@endrift @Prof9 @obskyr