Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GB/GBC Audio Inaccuracy (Super Mario Bros. Deluxe, Donkey Kong '94, and potentially all GB/GBC games.) #2965

Closed
SplatJam opened this issue Jun 28, 2023 · 1 comment
Closed

GB/GBC Audio Inaccuracy (Super Mario Bros. Deluxe, Donkey Kong '94, and potentially all GB/GBC games.) #2965

SplatJam opened this issue Jun 28, 2023 · 1 comment
Labels
hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues severity:regression Issues that were not present in previous versions
Milestone
mGBA 0.10.3

Comments

@SplatJam
Copy link

SplatJam commented Jun 28, 2023 •
edited

Some of the sound effects in Super Mario Brothers Deluxe seem to be inaccurate in the latest update, most notably the enemy kick/player swap sound effect:

mariodxsound.mp4

However in a previous version of mgba (0.9.3) plays the sound correctly:

mariodxaudio_0_8_3.mp4

EDIT: Also apparently if a game is paused for too long some audio channels just stop working.
It happened with Deluxe but it also happened with Donkey Kong '94:

dkong.mp4

I think it would be best to rollback to the old audio system until these issues can be ironed out.
@SplatJam SplatJam changed the title GB/GBC Audio inaccuracy GB/GBC Audio Inaccuracy (Super Mario Bros. Deluxe) Jun 28, 2023
@SplatJam SplatJam changed the title GB/GBC Audio Inaccuracy (Super Mario Bros. Deluxe) GB/GBC Audio Inaccuracy (Super Mario Bros. Deluxe, Donkey Kong '94, and potentially all GB/GBC games.) Jun 29, 2023
@endrift
Copy link
Member

endrift commented Jun 29, 2023 •
edited

Regressed in 68f628a.

The new audio system cannot be rolled back, and it fixes too many things already. The issue with audio breaking if silent for too long has already been fixed post-0.10.2 anyway.

@endrift endrift added severity:regression Issues that were not present in previous versions platform:GB/GBC Game Boy/Game Boy Color-related issues hardware:audio Issues in the audio subsystem labels Jun 29, 2023
@endrift endrift added this to the mGBA 0.10.3 milestone Jun 29, 2023
endrift added a commit that referenced this issue Jun 29, 2023
@endrift
GB Audio: Fix channel 1 restarting if sweep applies after stop (fixes #…
0d353a7 
…2965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues severity:regression Issues that were not present in previous versions
Projects
None yet
Milestone
mGBA 0.10.3
Development

No branches or pull requests
2 participants
@endrift @SplatJam