Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading savestates break PSG channels #2793

Closed
getCursorsExe opened this issue Jan 21, 2023 · 2 comments
Closed

Loading savestates break PSG channels #2793

getCursorsExe opened this issue Jan 21, 2023 · 2 comments
Labels
blocked:needs info Not enough information to be fully investigated

Comments

@getCursorsExe
Copy link

Savestate implementation does not capture the state of PSG channels, causing minor audio glitches after loading a savestate.
This relates to #496 but that issue only occured due to PSG and FIFO channels desyncing on state load.

@endrift
Copy link
Member

endrift commented Jan 22, 2023

This is categorically false. It's possible that some state isn't captured properly, but it absolutely does capture the state. Please give me an example of a game and scene in the game where I can actually reproduce this glitching.

@endrift endrift added the blocked:needs info Not enough information to be fully investigated label Jan 22, 2023
@endrift
Copy link
Member

endrift commented Jan 30, 2023

Next time please file a real bug report, not a nonsensical analysis of a poorly described bug with no real information. I managed to fix this based on TASEmulators/BizHawk#2749, which is not a bug report you filed, nor contributed to at all. This bug report alone was useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked:needs info Not enough information to be fully investigated
Projects
None yet
Development

No branches or pull requests

2 participants