Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplayer: Warn when two players use the same save file #2750

Closed
ahigerd opened this issue Dec 12, 2022 · 3 comments
Closed

Multiplayer: Warn when two players use the same save file #2750

ahigerd opened this issue Dec 12, 2022 · 3 comments
Milestone
mGBA 0.10.2

Comments

@ahigerd
Copy link
Contributor

ahigerd commented Dec 12, 2022

When two multiplayer windows use the same save file, they're pretty likely to scribble inconsistent data into the save file.

There's no way to fix that behavior, but the impact on the user can be mitigated by issuing a warning if more than one window has selected the same save file. Alternatively, we might want to consider disabling the options that are in use in other windows so that they can't be selected.
@endrift endrift added this to the mGBA 0.10.2 milestone Dec 16, 2022
@endrift
Copy link
Member

endrift commented Mar 11, 2023 •
edited

Looking at the code, it looks like that's only supposed to happen if there's only one player. HOWEVER, in the case that player 1 starts a game with a player >1 save, then opens the window and loads the game, it can still go wrong.

Hypothetically, I could swap that player's save with the .sav instead of the .saX it's using instead of a warning, but that might be confusing too.

@qwetboy10
Copy link

Hi. I'm a UT Student taking the virtualization course. Could I ask to work on this issue? Thanks.

@endrift
Copy link
Member

endrift commented Mar 27, 2023

No, this one is kind of time-sensitive and I already have something in the works.

endrift added a commit that referenced this issue Mar 27, 2023
@endrift
Qt: Swap P1 and other player's save if P1 loaded it first (closes #2750)
7da48a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
mGBA 0.10.2
Development

No branches or pull requests
3 participants
@endrift @ahigerd @qwetboy10