Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprite conflict in Drill Dozer (regression) #2391

Closed
Chariblaze opened this issue Dec 25, 2021 · 3 comments
Closed

Sprite conflict in Drill Dozer (regression) #2391

Chariblaze opened this issue Dec 25, 2021 · 3 comments
Labels
blocked:needs hw testing May be present on actual hardware, but need confirmation platform:GBA Game Boy Advance-related issues severity:regression Issues that were not present in previous versions
Milestone
mGBA 0.10.0

Comments

@Chariblaze
Copy link

In the Area 4-2 miniboss fight, the bottom-left door sprite disappears when the miniboss tumbling around is on the same line.

Drill Dozer (USA)-0

Tested with mGBA 0.9.3 using default settings on Windows 10 64-bit and Switch. The issue is not present in old builds. It seemed to break specifically with 6199-d61d9ef.

Bug report ZIP (added a save state that works in 6198-ff0b7af)

0.9.3 and 6199-d61d9ef:

Bugged.--.0.9.3.and.6199-d61d9ef.mp4

6198-ff0b7af (correct behavior afaik):

Correct.--.6198-ff0b7af.mp4

(builds are currently available on this page: https://mgba.io/builds/49/)
@endrift
Copy link
Member

endrift commented Dec 26, 2021

d61d9ef doesn't affect emulation at all, so that's kinda strange.

@Chariblaze
Copy link
Author

Ah whoops, 6199 is labelled with & links to d61d9ef on the builds page, but the actual commit in the title bar is 031049c.

drill-dozer-sprite-bug-6199-031049cd0

@endrift
Copy link
Member

endrift commented Dec 26, 2021

I thought I fixed that bug.

@endrift endrift added blocked:needs hw testing May be present on actual hardware, but need confirmation platform:GBA Game Boy Advance-related issues severity:regression Issues that were not present in previous versions labels Dec 26, 2021
@endrift endrift added this to the mGBA 0.10.0 milestone Dec 26, 2021
endrift added a commit that referenced this issue Jan 31, 2022
@endrift
GBA Video: Ignore horizontally off-screen sprite timing (fixes #2391)
745b1c7
rtomasa pushed a commit to rtomasa/mgba that referenced this issue Sep 15, 2023
@endrift @rtomasa
GBA Video: Ignore horizontally off-screen sprite timing (fixes mgba-e…
582649b 
…mu#2391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked:needs hw testing May be present on actual hardware, but need confirmation platform:GBA Game Boy Advance-related issues severity:regression Issues that were not present in previous versions
Projects
None yet
Milestone
mGBA 0.10.0
Development

No branches or pull requests
2 participants
@endrift @Chariblaze