Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt/macOS: unpausing won't update display #1899

Closed
lunasorcery opened this issue Sep 28, 2020 · 2 comments
Closed

Qt/macOS: unpausing won't update display #1899

lunasorcery opened this issue Sep 28, 2020 · 2 comments
Labels
port:Qt Affects the Qt version (the standard desktop version) system:macOS Affect running on macOS
Milestone
mGBA 0.9.0

Comments

@lunasorcery
Copy link

lunasorcery commented Sep 28, 2020 •
edited

Pausing the emulation will correctly pause the display, unpausing will resume emulation but the display will be stuck on the paused frame. Further pauses will update the display to new paused frames but will never resume live visuals. This occurs with both Cmd+P and pausing via the menu.

Observed on a3d5e34 (latest master at time of posting).
Appears to have been introduced at ca85595 (checked via git bisect).
Only occurs on the Qt build - SDL version is unaffected.
This affects both GB and GBA emulation.
Observed on macOS 10.14.6, on a 2016 MBP (2.9 GHz Intel Core i5, Intel Iris Graphics 550 1536 MB)
@endrift endrift added system:macOS Affect running on macOS port:Qt Affects the Qt version (the standard desktop version) labels Sep 28, 2020
@endrift
Copy link
Member

endrift commented Sep 28, 2020

I assume this also happens with the OpenGL 1.x display driver, but not with the Software display driver?

@lunasorcery
Copy link
Author

Yes - this only seems to occur on the GL and GL 1.x drivers, Software appears unaffected.

I've got a change at lunasorcery@2d3c13c that appears to resolve it but I'm not confident it's the 'correct' fix.

@endrift endrift added this to the mGBA 0.9.0 milestone Oct 1, 2020
endrift added a commit that referenced this issue Oct 5, 2020
@endrift
Qt: Fix drawing on macOS break when using OpenGL (fixes #1899)
fc520d6
@endrift endrift closed this as completed in 9bbdd2b Oct 5, 2020
@RetroEdit RetroEdit reopened this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
port:Qt Affects the Qt version (the standard desktop version) system:macOS Affect running on macOS
Projects
None yet
Milestone
mGBA 0.9.0
Development

No branches or pull requests
3 participants
@endrift @lunasorcery @RetroEdit