Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flickering and graphical glitches] Advance wars 1 and 2 #1823

Closed
cjlaborde opened this issue Jul 23, 2020 · 7 comments
Closed

[Flickering and graphical glitches] Advance wars 1 and 2 #1823

cjlaborde opened this issue Jul 23, 2020 · 7 comments
Labels
platform:GBA Game Boy Advance-related issues severity:regression Issues that were not present in previous versions severity:release blocker Major issues that prevent a release from being cut software:priority game Issues in widely played popular games
Milestone
mGBA 0.9.0

Comments

@cjlaborde
Copy link

cjlaborde commented Jul 23, 2020 •
edited

flickering5
Here is another problem

mgbaAW2
Not sure if this is the exact same issue, but I ran into this with Advance Wars 2 dialogue. The issue persists whether or not I have interframe blending or sync to video enabled (in the gif both are enabled).

I have same issue with advanced wars
flickering3

I am using Retoarch with MGBA on linux.
Issue seems to be happening more often when there is Dialog text at the top of the screen.

@tnelling Seems to have same issue.
@endrift endrift added platform:GBA Game Boy Advance-related issues software:priority game Issues in widely played popular games severity:regression Issues that were not present in previous versions labels Jul 23, 2020
@endrift endrift added this to the mGBA 0.8.3 milestone Jul 23, 2020
@endrift
Copy link
Member

endrift commented Jul 23, 2020

Retroarch huh. I believe they're currently basing off of mGBA 0.8.2.

@cjlaborde
Copy link
Author

Here are my specs
image

@tnelling
Copy link

tnelling commented Jul 23, 2020 •
edited

When I encountered the issue, I was running mGBA 0.8.1 on Windows 10.

@endrift endrift mentioned this issue Jul 23, 2020
Closed
@cjlaborde
Copy link
Author

cjlaborde commented Jul 23, 2020 •
edited

I am using VBA-M now and doesn't have this issue.
Seems VBA had issues with Advance Wars 2 in the Past but they fixed it as in mentioned in the screenshot below.
https://emulation.gametechwiki.com/index.php/Game_Boy_Advance_emulators
image
The good news is you can use mGBA save file on VBA-M so you can use both with no problem.

@endrift
Copy link
Member

endrift commented Jul 23, 2020

It doesn't actually mention what issues it had though. (Also it's VBA, not VGA.)

@endrift
Copy link
Member

endrift commented Jul 24, 2020 •
edited

Regressed in 223be49. That means you can use a real BIOS to temporarily work around the issue. The bug appears to be related to how long it takes for division to occur. That commit made it so that division in mGBA takes non-zero time in the HLE BIOS. In the regular BIOS, division is an interruptable process, but in the HLE BIOS it's not, so since it now takes non-zero time that can push some things back to happening too late. This may be a tricky one to solve without using a proper BIOS.

@endrift
Copy link
Member

endrift commented Aug 1, 2020

It doesn't look like I'll be able to fix this in 0.8.3 (or 0.8.x at all), so I'm retargeting it for 0.9.0 (as a blocker)

@endrift endrift modified the milestones: mGBA 0.8.3, mGBA 0.9.0 Aug 1, 2020
@endrift endrift added the severity:release blocker Major issues that prevent a release from being cut label Aug 1, 2020
@endrift endrift mentioned this issue Aug 5, 2020
Closed
@endrift endrift closed this as completed in 38613b5 Aug 7, 2020
RetroEdit pushed a commit to TASEmulators/mgba that referenced this issue Aug 29, 2020
@endrift @RetroEdit
GBA BIOS: Make HLE BIOS calls interruptable (fixes mgba-emu#1711, fixes
c466449 
mgba-emu#1823)
vadosnaprimer pushed a commit to TASEmulators/mgba that referenced this issue Aug 30, 2020
@endrift
GBA BIOS: Make HLE BIOS calls interruptable (fixes mgba-emu#1711, fixes
e1c51a1 
mgba-emu#1823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:GBA Game Boy Advance-related issues severity:regression Issues that were not present in previous versions severity:release blocker Major issues that prevent a release from being cut software:priority game Issues in widely played popular games
Projects
None yet
Milestone
mGBA 0.9.0
Development

No branches or pull requests
3 participants
@endrift @tnelling @cjlaborde