Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Real time clock setting on italian localization is broken #1798

Closed
EddyHg80 opened this issue Jun 19, 2020 · 3 comments · Fixed by #1809
Closed

Real time clock setting on italian localization is broken #1798

EddyHg80 opened this issue Jun 19, 2020 · 3 comments · Fixed by #1809
Labels
category:help wanted Could use additional people helping out

Comments

@EddyHg80
Copy link
Contributor

Annotazione 2020-06-19 133630

Hey there's this problem with real time clock, only in the italian localization (I checked english, german and french and they are fine).
Also in game it doesn't work, even if I use one of the working languages above, it's always night.
It's strange because on VBA-M it actually works, so I think it's not the rom's fault.
@EddyHg80 EddyHg80 changed the title Real time clock settings on italian localization are broken. Real time clock settings on italian localization is broken Jun 19, 2020
@EddyHg80 EddyHg80 changed the title Real time clock settings on italian localization is broken Real time clock setting on italian localization is broken Jun 19, 2020
@endrift endrift added the category:help wanted Could use additional people helping out label Jun 23, 2020
@endrift
Copy link
Member

endrift commented Jun 23, 2020

We need an Italian translator to fix this, and the Italian translation as-is was a one-off.

@EddyHg80
Copy link
Contributor Author

EddyHg80 commented Jun 24, 2020 •
edited

I can actually help out! I'm not a programmer but I know how to use github; if you show me the files to edit I think I can try to contribute.
Do you think fix the localization will fix the real time clock too?

@RetroEdit
Copy link

RetroEdit commented Jun 24, 2020 •
edited

Fixing the localization will only fix the text displayed.

In regards to RTC, it can be tricky for ROM hacks. Some ROM hacks were created using VBA as a reference, so they have bugs on more accurate emulators like mGBA and real-console.

As for what file contains the translated text, I think it's src/platform/qt/ts/mgba-it.ts.

Edit: Or I'm actually not clear what the problem with the Italian version is? Is it a functional problem or a mistranslation?

@EddyHg80 EddyHg80 mentioned this issue Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:help wanted Could use additional people helping out
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix italian real time clock translation
3 participants
@endrift @EddyHg80 @RetroEdit