Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mosaic + Background rotation does not match hardware #1691

Closed
felixjones opened this issue Mar 14, 2020 · 0 comments
Closed

Mosaic + Background rotation does not match hardware #1691

felixjones opened this issue Mar 14, 2020 · 0 comments
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues
Milestone
mGBA 0.9.1

Comments

@felixjones
Copy link
Contributor

Rom Download
2020-03-14.zip

Video clip of ROM on hardware
IMG_20200314_174009_MP.zip

At the bottom right of the below screenshot where the background has been rotated the mosaic effect is not applied to the rotation - so the edge of the background is smoother than on actual hardware.

mGBA 0.8.0 and 0.8.1 (software renderer)
rom-0

Notice how the bottom right pixels are much more blocky on hardware
vlcsnap-2020-03-14-17h56m49s315
@endrift endrift added hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues labels Aug 14, 2020
@endrift endrift added this to the mGBA 0.9.1 milestone Mar 21, 2021
@endrift endrift closed this as completed in be8b95f Apr 2, 2021
endrift added a commit that referenced this issue Apr 13, 2021
@endrift
GBA Video: Fix mode 3-5 overflow with mosaic (fixes #1691)
91cfbbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues
Projects
None yet
Milestone
mGBA 0.9.1
Development

No branches or pull requests
2 participants
@endrift @felixjones