Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown option keeps handle on rom files #1659

Closed
AsparagusEduardo opened this issue Feb 2, 2020 · 4 comments
Closed

Shutdown option keeps handle on rom files #1659

AsparagusEduardo opened this issue Feb 2, 2020 · 4 comments
Labels
port:Qt Affects the Qt version (the standard desktop version) system:Windows Affects running on Windows

Comments

@AsparagusEduardo
Copy link

AsparagusEduardo commented Feb 2, 2020 •
edited

I don't know if this intentional behaviour, but by using the shutdown option it doesn't let me recopile the rom file.

image

EDIT: Tried it in 0.7.2 and 0.7.3 and the issue doesn't happen, so it must've been introduced in 0.8.0
@endrift endrift added port:Qt Affects the Qt version (the standard desktop version) severity:regression Issues that were not present in previous versions labels Feb 2, 2020
@endrift
Copy link
Member

endrift commented Feb 2, 2020

On my end it looks like it's just the window title not getting updated; the file handle appears to be closed. Did you have any other windows open when you hit Shutdown?

@AsparagusEduardo
Copy link
Author

No, I didn't have any other mGBA windows open
I was referred to make an issue report from the pokeemerald project Discord when I tried compiling after pressing Shutdown, and they told me that the common issue with that error is the file handle being open.
image

@endrift
Copy link
Member

endrift commented Feb 3, 2020 •
edited

So I can reproduce this, but the file handle has definitely been closed. Process Explorer can't see it. I wonder if I'm not unmapping the memory properly before closing it.

E] That appears to be exactly what's happening.

@endrift endrift added system:Windows Affects running on Windows and removed severity:regression Issues that were not present in previous versions labels Feb 4, 2020
@endrift
Copy link
Member

endrift commented Feb 4, 2020

Should have a fix for this tonight.

@endrift endrift closed this as completed in baeb353 Feb 5, 2020
endrift added a commit that referenced this issue Feb 8, 2020
@endrift
VFS: Fix handle leak when double-mapping (fixes #1659)
5d58944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
port:Qt Affects the Qt version (the standard desktop version) system:Windows Affects running on Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endrift @AsparagusEduardo