Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Famicom Mini series: corrupted graphics with OpenGL renderer on Windows in certain games #1635

Closed
angrylion7 opened this issue Jan 23, 2020 · 2 comments
Closed

Famicom Mini series: corrupted graphics with OpenGL renderer on Windows in certain games #1635

angrylion7 opened this issue Jan 23, 2020 · 2 comments
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues
Milestone
mGBA 0.9.0

Comments

@angrylion7
Copy link

I'm on Windows 7 x64, using a GeForce GT630 1 GB VRAM GPU (GK208 chip) and the latest nVidia driver v441.87. Super Mario Bros. 2 and Metroid from Famicom Mini Series show black space instead of lower row(s) of emulated background tiles as shown on the screenshot, and only do this with the OpenGL renderer. Many other entries in the Famicom Mini Series don't suffer from this, and neither does Metroid from the Classic NES series, curiously. This happens as far back as 20ea552. I also tested 921f3f8, and it's the same, only the background in SMB2 is not rendered properly at all. I assumed that's because the OpenGL renderer was not mature enough by the time of 921f3f8, and I don't need to go further back, am I wrong?
smb2
@endrift
Copy link
Member

endrift commented Jan 23, 2020

This appears to be because sprite cycle counting isn't implemented yet.

@endrift endrift added this to the mGBA 0.9.0 milestone Jan 23, 2020
endrift added a commit that referenced this issue Jun 10, 2020
@endrift
GBA Video: Add sprite cycle counting to GL (fixes #1635)
a87cde8
@endrift endrift modified the milestones: mGBA 0.9.0, mGBA 0.8.2 Jun 10, 2020
endrift added a commit that referenced this issue Jun 15, 2020
@endrift
Revert "GBA Video: Add sprite cycle counting to GL (fixes #1635)"
7f975f5 
This reverts commit a87cde8.
endrift added a commit that referenced this issue Jun 15, 2020
@endrift
Revert "GBA Video: Add sprite cycle counting to GL (fixes #1635)"
f0b03d7 
This reverts commit 318a96b.
@endrift endrift modified the milestones: mGBA 0.8.2, mGBA 0.9.0 Jun 15, 2020
@endrift endrift reopened this Jun 15, 2020
@endrift
Copy link
Member

endrift commented Jun 15, 2020

Helps if I actually do this per scanline, which I wasn't.

@endrift endrift added hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues labels Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues
Projects
None yet
Milestone
mGBA 0.9.0
Development

No branches or pull requests
2 participants
@endrift @angrylion7