Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Muting immediately after pausing causes the screen to go black. #1612

Closed
RetroEdit opened this issue Jan 6, 2020 · 7 comments
Closed

Comments

@RetroEdit
Copy link

This is really just a minor inconvenience, so it needn't be fixed for 0.8, but it's annoying and it shouldn't happen.

@RetroEdit RetroEdit changed the title [Qt] Muting causes the screen to go black. [Qt] Muting immediately after pausing causes the screen to go black. Jan 6, 2020
@endrift
Copy link
Member

endrift commented Jan 6, 2020

I can't reproduce. Can you give me some more info about your setup?

@RetroEdit
Copy link
Author

RetroEdit commented Jan 6, 2020

Windows 8.1, Intel Pentium N3540 processor. Happens straight from extraction with the latest nightly as of this writing, 6008-ccdbcf6, but also occurs in prior versions going back to at least 0.7.3 (probably before; I can check if you want) Actually, not quite, but there's some other interesting behavior before then; I'll write a full report in my next comment.

If there's anything else that would be useful, please let me know.

@RetroEdit
Copy link
Author

Here's a timeline of how this bug appears to have progressed:

  • The bug did not appear in 0.6.3
  • A similar bug appears in 0.7 beta 1, but instead the screen becomes vertically flipped, and solely when unmuting.
  • In 0.7.0, muting toggles between the screen being vertically flipped and not, though occasionally if one is spam-pressing mute while paused, it skips a cycle.
  • The current incarnation begins in 0.7.1

So then I tried to trace down when this stuff was introduced in the hourlies. Unfortunately, the hourlies appear to derive from master, whereas the releases derive from 0.7, so they aren't quite comparable; I wasn't able to find the vertical screen flipping version in the hourlies. But I was able to find the black screen version appears to have been introduced in 5202-7cc09c7

@endrift
Copy link
Member

endrift commented Jan 6, 2020

What GPU?

Also that's weird, muting it shouldn't affect how things are drawn. Are you using the menu to mute it or a hotkey?

@RetroEdit
Copy link
Author

My GPU is Intel HD Graphics and I'm using the menu to mute it.

Also, just to be clear, the screen does not continue to be black once unpaused again, sorry I didn't mention that early, but that's why I said it wasn't high-priority.

@endrift endrift closed this as completed in 7b08a3e Jan 9, 2020
@endrift
Copy link
Member

endrift commented Jan 9, 2020

Should be fixed now, let me know

@RetroEdit
Copy link
Author

Worked like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants