Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBC - Loading quick saves on screen transitions makes games mute #1305

Closed
themalu866 opened this issue Feb 13, 2019 · 6 comments
Closed

GBC - Loading quick saves on screen transitions makes games mute #1305

themalu866 opened this issue Feb 13, 2019 · 6 comments
Labels
feature:savestates Issues in save state implementation hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues
Milestone
mGBA 0.9.0

Comments

@themalu866
Copy link

Playing on Windows, the music plays just fine and I quick save, then I die, or go to the next level, or enter a bonus/warp, it doesn't matter, at the exact moment when the screen fades and there's a brief SILENCE if I quick load on that moment the level music don't play and only returns if I die or go to different screen.

As far as I know this only happens when there is this quiet moment, it doesn't seem to happen with games where the transition is instantaneous but I not sure. And maybe that happens with GB games too.

Donkey Kong Land 2.zip

Donkey Kong Land III.zip
@endrift
Copy link
Member

endrift commented Aug 12, 2020

This is likely fixed on latest dev builds. Please retest.

@endrift endrift added the blocked:needs retest Needs a retest to confirm if it's fixed label Aug 12, 2020
@themalu866
Copy link
Author

I checked on Donkey Kong Land III and still happens.

@endrift
Copy link
Member

endrift commented Aug 24, 2020

Was this with a save state you made on the newer builds? Old save states may have been created with errors in them as a result of bugs.

@endrift
Copy link
Member

endrift commented Aug 24, 2020

Never mind, I can reproduce.

@endrift endrift added hardware:audio Issues in the audio subsystem feature:savestates Issues in save state implementation platform:GB/GBC Game Boy/Game Boy Color-related issues and removed blocked:needs retest Needs a retest to confirm if it's fixed labels Aug 24, 2020
@endrift endrift added this to the mGBA 0.9.0 milestone Aug 24, 2020
@themalu866
Copy link
Author

It's a new save but this time the glitch is kinda different.
If I quick load at silent moments it still gets mute, but if I close mgba, quick load really fast then the music partially plays and if I wait for the title screen to appears and then load it the music plays fine.
This is only happening with Donkey Kong Land III, Donkey Kong Land 2 is fine.
Donkey Kong Land III.zip

endrift added a commit that referenced this issue Aug 24, 2020
@endrift
GB Audio: Fix deserializing while audio was disabled (fixes #1305)
f7f8688
@endrift
Copy link
Member

endrift commented Aug 24, 2020

Turns out the commit I thought I fixed this in broke something related in the process. It's properly fixed now.

RetroEdit pushed a commit to TASEmulators/mgba that referenced this issue Sep 13, 2020
@endrift @RetroEdit
GB Audio: Fix deserializing while audio was disabled (fixes mgba-emu#…
488f08b 
…1305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:savestates Issues in save state implementation hardware:audio Issues in the audio subsystem platform:GB/GBC Game Boy/Game Boy Color-related issues
Projects
None yet
Milestone
mGBA 0.9.0
Development

No branches or pull requests
2 participants
@endrift @themalu866