Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gunstar Super Heroes / Gunstar Future Heroes - status bar has graphical glitches #1279

Closed
YaketyJoe opened this issue Jan 27, 2019 · 7 comments
Closed

Gunstar Super Heroes / Gunstar Future Heroes - status bar has graphical glitches #1279

YaketyJoe opened this issue Jan 27, 2019 · 7 comments
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library
Milestone
mGBA 0.8.2

Comments

@YaketyJoe
Copy link

YaketyJoe commented Jan 27, 2019 •
edited

OS and Version: Windows - mGBA version 0.7.0 - released Jan 26, 2019.

In the games "Gunstar Super Heroes / Gunstar Future Heroes", the top energy bar has layering issues, causing graphical glitches. Part of the game goes over the weapon icons, when it does not in real hardware.

This issue clearly happens on first boss and on the second level. Please see images below:

gunstar future heroes europe en ja fr de es it -3
gunstar future heroes europe en ja fr de es it -0
gunstar future heroes europe en ja fr de es it -1
gunstar future heroes europe en ja fr de es it -2
@endrift
Copy link
Member

endrift commented Jan 27, 2019

Please provide a savestate.

@YaketyJoe
Copy link
Author

Sure, here is a Save State, from a No-Intro rom:
Gunstar Future Heroes - bug01ss.zip

@YaketyJoe YaketyJoe changed the title Gunstar Super Heroes / Gunstar Future Heroes Gunstar Super Heroes / Gunstar Future Heroes - status bar has graphical glitches Jan 27, 2019
@endrift endrift added severity:minor bug Issues that only have a minor impact on the library platform:GBA Game Boy Advance-related issues hardware:2D Issues in the 2D/pixel pipeline subsystem labels Jan 27, 2019
@endrift endrift added this to the mGBA 0.7.1 milestone Jan 27, 2019
@endrift endrift modified the milestones: mGBA 0.7.1, mGBA 0.7.2 Feb 25, 2019
@endrift endrift modified the milestones: mGBA 0.7.2, mGBA 0.8.0 May 8, 2019
@endrift endrift modified the milestones: mGBA 0.8.0, mGBA 0.9.0 Oct 5, 2019
@fleroviux
Copy link

fleroviux commented Jun 9, 2020 •
edited

fwiw this game is massively exceeding the scanline cycle limit for OBJs and expects OBJs beyond that limit to get discarded. implementing this will fix the issue.
there still will be small cut-ins at the bottom of the status bar, but those appear to happen on HW as well.

@endrift
Copy link
Member

endrift commented Jun 9, 2020

Strange, I already implement the cycle limit for OBJs.

@fleroviux
Copy link

image
That's strange then. I've only checked the first stage until the first boss so far which has the same problem as NanoboyAdvance had until recently. Implementing the cycle limit fixed it for me.

@fleroviux
Copy link

Just a wild guess: are you maybe rendering OBJs in reverse order (127 first, 0 last)?
That's something I changed recently and reverting that change Gunstar Super Heroes breaks.

endrift added a commit that referenced this issue Jun 10, 2020
@endrift
GBA Video: Simplify sprite cycle counting (fixes #1279)
0216557
@endrift
Copy link
Member

endrift commented Jun 10, 2020

Looks like my sprite cycle implementation was buggy! Thanks for the help @fleroviux.

@endrift endrift modified the milestones: mGBA 0.9.0, mGBA 0.8.2 Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library
Projects
None yet
Milestone
mGBA 0.8.2
Development

No branches or pull requests
3 participants
@endrift @fleroviux @YaketyJoe