Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metroid Zero Mission: freezes at the endgame cutscene #1012

Closed
mrachinskiy opened this issue Mar 12, 2018 · 8 comments
Closed

Metroid Zero Mission: freezes at the endgame cutscene #1012

mrachinskiy opened this issue Mar 12, 2018 · 8 comments
Labels
platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library software:priority game Issues in widely played popular games
Milestone
mGBA 0.7.0

Comments

@mrachinskiy
Copy link

Game freezes in certain point of endgame cutscene (when ship starts to blow up). But issue is not presented in older releases.

Broken: d22315c dev build and 0.6.1 release.
Works: 0.5.2 release.

Save state for 0.6.1 and later
Save state for 0.5.2

Reproduce issue:

  1. Use 0.6.1 release or devbuild (d22315c)
  2. Load save state
  3. Unpause the game
  4. Board escape pod to the right
  5. Wait for cutscene to freeze
@Cibomatto2002
Copy link

Download mGBA-build-2018-03-11-win32-5047-d22315cba5fb7d8ec6f9b2ae70cf69ecdbde9a88 still happens.

@endrift
Copy link
Member

endrift commented Mar 18, 2018 •
edited

Is this broken in 0.6.0 too?

E] Confirmed broken in 0.6.0 too.

@endrift endrift added this to the mGBA 0.6.2 milestone Mar 18, 2018
@endrift endrift added severity:minor bug Issues that only have a minor impact on the library platform:GBA Game Boy Advance-related issues labels Mar 18, 2018
@sergiobenrocha2 sergiobenrocha2 mentioned this issue Mar 19, 2018
Closed
@endrift endrift added the software:priority game Issues in widely played popular games label Mar 21, 2018
@endrift
Copy link
Member

endrift commented Mar 27, 2018 •
edited

Regressed during the mTiming cutover (after e423cd4 but before 9aa6d8f). Seems to be related to either timers or DMAs.

@endrift
Copy link
Member

endrift commented Mar 28, 2018

I'm not 100% sure this fix actually fixes it, but in my testing it seemed to. Let me know if it doesn't and I'll reopen the bug.

@mrachinskiy
Copy link
Author

Tested fc53fc9, no freezes in the cutscene. Thank you!

endrift added a commit that referenced this issue May 26, 2018
@endrift
Timer: Slightly restructure timer updating (fixes #1087, reopens #1012)
e2a5efe
@endrift endrift reopened this May 26, 2018
@endrift
Copy link
Member

endrift commented May 26, 2018

My fix for this broke a bunch of other stuff unfortunately.

@endrift endrift modified the milestones: mGBA 0.6.2, mGBA 0.7.0 Sep 16, 2018
@endrift
Copy link
Member

endrift commented Sep 16, 2018

Does this reproduce on latest? The 0.6.1 state freezes but the 0.5.2 state works, and playing through normally worked on my one attempt.

@mrachinskiy
Copy link
Author

I have tested on 108b0fc dev build, and I got results similar to yours: 0.6.1 state freezes, 0.5.2 state works, and loading from in-game save works (which I assume would be equal to a normal playthrough).
Looks like it has been fixed!

@endrift endrift closed this as completed Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:GBA Game Boy Advance-related issues severity:minor bug Issues that only have a minor impact on the library software:priority game Issues in widely played popular games
Projects
None yet
Milestone
mGBA 0.7.0
Development

No branches or pull requests
3 participants
@endrift @mrachinskiy @Cibomatto2002