Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical sprite mosaic bug #1008

Closed
CaptainCaffeine opened this issue Mar 9, 2018 · 2 comments
Closed

Vertical sprite mosaic bug #1008

CaptainCaffeine opened this issue Mar 9, 2018 · 2 comments
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem severity:minor bug Issues that only have a minor impact on the library
Milestone
mGBA 0.7.2

Comments

@CaptainCaffeine
Copy link

When comparing mosaic output between mGBA and my own emulator, I noticed that the bottom block of vertical mosaic sprites would sometimes render incorrectly in mGBA. Below are pictures of Tonc's mos_demo.gba running on hardware and in mGBA, with a horizontal mosaic of 2 and a vertical mosaic of 15. The yellow fangs of the metroid on the left should be half the length of the blue fangs of the metroid on the right, but on mGBA they're the same length.
mgba_tonc_mos_demo_bug
mos_demo_hardware

The demo can be downloaded from www.coranac.com/files/tonc-bin.zip. You can use the d-pad to adjust the mosaic of the sprite, and A+d-pad to adjust the mosaic of the background.
@endrift
Copy link
Member

endrift commented Mar 9, 2018

This appears to affect the intro cutscene in Aria of Sorrow:

a2ce-8 (old behavior) vs a2ce-7 (fixed behavior)

Compared against hardware:
screen shot 2018-03-08 at 10 51 35 pm

Unfortunately my fix appears to break the Minish Cap test, so I'll need to take a closer look at it when I have more time.

@endrift endrift added this to the mGBA 0.6.2 milestone Mar 9, 2018
@endrift endrift added severity:minor bug Issues that only have a minor impact on the library hardware:2D Issues in the 2D/pixel pipeline subsystem labels Mar 9, 2018
@endrift endrift modified the milestones: mGBA 0.6.2, mGBA 0.7.0 Apr 14, 2018
@endrift endrift modified the milestones: mGBA 0.7.0, mGBA 0.8.0 Sep 2, 2018
@endrift endrift modified the milestones: mGBA 0.8.0, mGBA 0.7.2 May 21, 2019
endrift added a commit that referenced this issue May 21, 2019
@endrift
GBA Video: Fix sprite mosaic clamping (fixes #1008)
e6eaf19
@endrift
Copy link
Member

endrift commented May 21, 2019

Finally figured out how to fix this properly. Thanks for finding it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hardware:2D Issues in the 2D/pixel pipeline subsystem severity:minor bug Issues that only have a minor impact on the library
Projects
None yet
Milestone
mGBA 0.7.2
Development

No branches or pull requests
2 participants
@endrift @CaptainCaffeine