Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pops in audio of M&L:SS #546

Closed
waddlesplash opened this issue Mar 22, 2017 · 11 comments
Closed

Pops in audio of M&L:SS #546

waddlesplash opened this issue Mar 22, 2017 · 11 comments
Labels
hardware:audio Issues in the audio subsystem
Milestone

Comments

@waddlesplash
Copy link
Contributor

Easily noticed with headphones on Stardust Fields and the warp pipe music at least. (haven't gotten farther so can't say where else)

I can make a recording if you're unable to reproduce.

@sergiobenrocha2
Copy link
Contributor

Pokemon Emerald, go to a region you can change the route easily (i'm testing in route 118 / 123), you'll notice some noise in the transition

You can notice too in the Continue screen, when the music is ending/fading

@endrift endrift added the hardware:audio Issues in the audio subsystem label Mar 28, 2017
@lotharsm
Copy link
Member

lotharsm commented Apr 4, 2017

I have similar clicking issues in the Pokémon Crystal intro. At the beginning, you hear a clicking/crackling noise when the Unowns appeared, and also during the Gamefreak logo. Basically, you hear a popping noise everytime a quite short sound is played.

I uploaded a video showing the issue to Youtube:

https://www.youtube.com/watch?v=X4nfbHO1aoc

Please also note that I think that there's a sound issue during the Pokemon intro. When the grass moves the second time [at 0:20 and 0:21], it seems that the sound of the second grass movement is wrong. I have to verify this with another emulator.

@waddlesplash
Copy link
Contributor Author

Yep, the pops are exactly what I'm experiencing.

@MWisBest
Copy link

MWisBest commented Apr 7, 2017

This may be a duplicate of #461 . If you change the FPS target to 60 instead of Native (59.7), do the pops become much less frequent?

@waddlesplash
Copy link
Contributor Author

My FPS target is already set to 60. I changed it to 59.7, and the pops are just as frequent.

@lotharsm
Copy link
Member

lotharsm commented Apr 7, 2017

Same here. No changes between 59.7 and 60 FPS.

@PrincessPleco
Copy link

PrincessPleco commented Apr 8, 2017

Take note please: At some point my PC stopped behaving differently on different FPS settings. For whatever reason (hardware change? Sound options change? Don't know...). Now both settings pop the same as the 60 FPS setting did before (and it was the option with less popping). Which is not too bad, but still noticeable. I still use the Mother 3 title screen for testing.

@endrift
Copy link
Member

endrift commented Apr 21, 2017

Can you try bisecting this?

@sergiobenrocha2
Copy link
Contributor

It started with 8ac6f83

@endrift endrift added this to the 0.6.0 milestone Jun 17, 2017
@endrift
Copy link
Member

endrift commented Jun 17, 2017

Audio popping is coming from PSG channel 1. It makes a pop every time it plays a note.

@endrift
Copy link
Member

endrift commented Jun 17, 2017

Note that this fixes many but not all of the audio issues with Crystal. And yeah the grass effect sounds wrong to me, but I haven't confirmed it yet.

lotharsm pushed a commit to lotharsm/mgba that referenced this issue Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardware:audio Issues in the audio subsystem
Projects
None yet
Development

No branches or pull requests

6 participants